Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_pipeline step supports detach mode #8374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanchaoli
Copy link
Contributor

@evanchaoli evanchaoli commented May 23, 2022

Changes proposed by this PR

If jobA of pipelineA call set_pipeline step to set pipelineB, then jobA is pipelineB's parent job. Currently Concourse has a logic that, if jobA sets another pipeline than pipelineB, then pipelineB will be automatically archived, which helps prevent from orphan pipelines.

set_pipeline step supports parameter team only when parent job runs from main team. We have a use case where a service pipeline running from main team may set child parent pipelines per needs. In other words, build-1 may set a child pipeline to teamA, then build-2 may set another child pipeline to teamB, and so on ... The behavior will trigger auto pipeline archive, thus this use case doesn't work with set_pipeline step.

I think my use case makes sense from main team. To not break the current logic, I am adding a detach flag to set_pipeline step. A parent job needs to explicitly turn on the flag so that child pipeline will be set in detach mode (same as set via fly set-pipeline, so that child pipeline will never be auto archived.

  • done

Notes to reviewer

Release Note

  • Add detach flag to set_pipeline step. Only the main team can set child pipelines in detach mode. In detach mode, child pipelines will never be automatically archived.

@evanchaoli evanchaoli requested a review from a team as a code owner May 23, 2022 08:50
@evanchaoli evanchaoli force-pushed the set-pipeline-detach branch 2 times, most recently from b533285 to 47db7c4 Compare May 23, 2022 10:27
@evanchaoli evanchaoli changed the title setpipeline supports detach mode set_pipeline step supports detach mode May 23, 2022
@xtremerui xtremerui self-assigned this May 23, 2022
Signed-off-by: Evan <chaol@vmware.com>
@evanchaoli evanchaoli added this to the v7.9.0 milestone Jun 1, 2022
@evanchaoli evanchaoli removed this from the v7.9.0 milestone Jul 15, 2022
@timota
Copy link

timota commented Jan 12, 2023

any plans to add this feature to concourse? It will be extremely useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants