remove "check build started/finished" metrics. #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
After several weeks of upgrading to 7.8, we found that the InfluxDB are quickly filling up. Then we identified the "check build started" and "check build finished" are two significant contributors.
Actually we don't monitor those two metrics at all. Because check builds are per resources, but real checks are per resource config scopes. Most of check builds just quickly terminate without actually running anything.
Notes to reviewer
Release Note
Removed "check build started" and "check build finished" metrics. To monitor checks, use "check started" and "check finished" instead.