Add --check-container-placement-strategy. #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan <chaol@vmware.com>
Signed-off-by: Evan <chaol@vmware.com>
evanchaoli
force-pushed
the
check-placement-strategy
branch
from
ec47a4d
to
6a9cb53
Compare
Signed-off-by: Evan <chaol@vmware.com>
xtremerui
reviewed
Oct 20, 2022
|
we will need PR to update concourse bosh release and helm chart for this new flag. |
Signed-off-by: Evan <chaol@vmware.com>
6 tasks
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
We experienced an outage last week. One result of the outage is that all workers over extremely overloaded. Each worker got thousands of containers and volumes, while we have been using "max-active-container" and "max-active-volumes" in container placement strategies.
Then I noticed that, Concourse hard-code "random" strategy for Lidar check containers. While Lidar check containers are recreated every 1 hour, so that in round of recreate, it will create 20K containers.
As a solution, I am adding
--check-container-placement-stragegy. We will usemax-active-container+max-active-volume+randomfor check container placement strategy.Notes to reviewer
Release Note