Fix a bad SQL for check gc. #8500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanchaoli
changed the title
|
what's the bad of the old and the good for the new? Is it just a refactor or there is a behaviour change? |
This is a db performance optimization. I just added PR description. |
Signed-off-by: Evan <chaol@vmware.com>
|
@xtremerui Why this PR cannot trigger concourse-ci to run? |
taylorsilva
reviewed
Aug 1, 2022
taylorsilva
reviewed
Aug 1, 2022
Signed-off-by: Evan <chaol@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #8454
We have noticed deadlock problems in our prod db, then we found this slow query, in the meantime we noticed
check_build_eventshad reached to 20 million tuples.Explain the SQL, we can see its cost is huge:
Then I worked out a new SQL:
On our db, the new SQL takes only 2 seconds to run, while the old SQL might take hours.
Now, I have disabled component
collector_checks, and use a 1 minute timer triggered pipeline to run the new SQL to do check GC. So far, it's running well.Notes to reviewer
Release Note