Use pq.Array to avoid hitting parameter limits #8528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
If you could add some tests that would be great. |
This fails with: pq: got 250000 parameters but PostgreSQL only supports 65535 parameters Signed-off-by: Adam Eijdenberg <adam.eijdenberg@defence.gov.au>
Signed-off-by: Adam Eijdenberg <adam.eijdenberg@defence.gov.au>
ae-govau
force-pushed
the
gh-8524/fix-reaper-with-pq-array
branch
from
d6dca8f
to
11f1bb7
Compare
|
Have added a test, and verified it produces the error before fixing it. |
|
We've hit this issue in an environment. Any ideas if this is going to be pushed into a public release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #8524 and supersedes PR #8525
Notes to reviewer
I've not yet tested it, but it looks like a very straight forward application of: https://www.opsdash.com/blog/postgres-arrays-golang.html