Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atc/db/lock: preallocate memory #8584

Merged
merged 1 commit into from Oct 11, 2022
Merged

atc/db/lock: preallocate memory #8584

merged 1 commit into from Oct 11, 2022

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Oct 6, 2022

What this PR does / why we need it:

Preallocate memory instead of enforcing an incremental growth. This will result in less work for the garbage collector.

@florianl
atc/db/lock: preallocate memory
f3d9c2c 
Signed-off-by: Florian Lehner <dev@der-flo.net>
@florianl florianl requested a review from a team as a code owner October 6, 2022 04:05
@evanchaoli evanchaoli self-requested a review October 11, 2022 02:20
@evanchaoli evanchaoli added this to the v7.9.0 milestone Oct 11, 2022
@evanchaoli
Copy link
Contributor

LGTM

xtremerui
xtremerui approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @evanchaoli

@xtremerui xtremerui merged commit eb8ec3e into concourse:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtremerui xtremerui xtremerui approved these changes

@evanchaoli evanchaoli Awaiting requested review from evanchaoli

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianl @evanchaoli @xtremerui