Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change id of table resource_config_scopes to bigint #8606

Merged
merged 1 commit into from Oct 26, 2022
Merged

Change id of table resource_config_scopes to bigint #8606

merged 1 commit into from Oct 26, 2022

Conversation

evanchaoli
Copy link
Contributor

Changes proposed by this PR

closes #8605

  • done

Notes to reviewer

Looks like resource_config_scope's id has been handle with int type in Concourse code, thus only db schema change is needed.

Release Note

Convert id column of the resource_config_scopes table and all tables referencing resource_config_scope_id to a bigint.

@evanchaoli evanchaoli requested a review from a team as a code owner October 26, 2022 01:13
@evanchaoli
Change id of table resource_config_scopes to bigint
1e43187 
Signed-off-by: Evan <chaol@vmware.com>
xtremerui
xtremerui approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xtremerui xtremerui merged commit 3bcf2ef into concourse:master Oct 26, 2022
@evanchaoli evanchaoli added this to the v7.9.0 milestone Oct 26, 2022
@evanchaoli evanchaoli mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xtremerui xtremerui xtremerui approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.

pq: integer out of range
2 participants
@evanchaoli @xtremerui