add shared path to SSM parameters #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtremerui
reviewed
Jun 14, 2023
Signed-off-by: Konstantin Troshin <k.troshin@fme.de>
taylorsilva
reviewed
Oct 12, 2023
It's been in total already about 9 months for many of the PRs hanging around. There also have been multiple releases during this time. Are there some issues that prevent merging or do you consider if you should merge at all? |
|
@taylorsilva ^^ |
|
sorry! Got busy at work |
taylorsilva
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Thanks again for the PR! Sorry for the delay reviewing. Concourse ain't my full time job anymore and my actual job has kept me busy. Thanks for the ping @xtremerui
|
No problem, just wanted to know where we are at :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
As of now, it is not possible to configure shared paths for AWS SSM cred manager as opposed to other cred managers such as Vault. Since it is easy to implement and useful, I propose to add a new parameter
--aws-ssm-shared-pathsimilar to the Vault cred manager. A path prefix rather than template (as for AWS SecretsManager) makes sense since in this case no default is needed and this parameter can be optional (as with Vault). This PR provides all the changes needed for this functionality.Notes to reviewer
Release Note