Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events logging when pod is not running for k8s topgun #8733

Merged
merged 1 commit into from Apr 21, 2023

Conversation

xtremerui
Copy link
Contributor

Changes proposed by this PR

Currently when a test fails in k8s topgun test with error like

  [FAILED] Timed out after 900.000s.

  expected all pods to be running

  Expected

      <bool>: false

  to be true

  In [It] at: github.com/concourse/concourse/topgun/k8s/k8s_suite_test.go:369

It is hard to debug since the build logs don't include the pod initializing events that usually contains the reason of the failure e.g. docker image pull failure.

The PR adds the method to log the pod events when pod fails to run.

  • done
  • todo

Release Note

  • Add method in k8s topgun test to log pod events when it is being initialized.

Signed-off-by: Rui Yang <ruiya@vmware.com>
@xtremerui xtremerui added the misc label Apr 20, 2023
@xtremerui xtremerui requested a review from a team as a code owner April 20, 2023 21:40
@xtremerui xtremerui merged commit 8a68dfd into master Apr 21, 2023
11 checks passed
@xtremerui xtremerui deleted the add-k8s-topgun-events-logging branch April 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant