switch to ubuntu:bionic for base image #256

chenbh · 2019-02-11T20:24:15Z

resolve compatibility issue between busybox vs coreutil timeout
alpine packages docker nicely, ubuntu requires adding docker's own repository
Image size is now 305mb -> 448mb

* resolve compatibility issue between busybox vs coreutil `timeout` Signed-off-by: Bohan Chen <bochen@pivotal.io>

The ubuntu package `docker` is outdated and we should be using `docker-ce` instead Signed-off-by: Bohan Chen <bochen@pivotal.io>

Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

cirocosta

Missing updates to the README to reflect the ability to now build and test with both alpine and ubuntu as base images.

It'd also be good to make sure that the removal of the -t flag is not a problem.

assets/common.sh

- busybox (alpine) `timeout` uses `-t` for duration - coreutils (ubuntu) `timeout` duration is a required argument - add logic to detect which linux distro and use the appropriate flags Signed-off-by: Bin Ju <bju@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

Signed-off-by: Bin Ju <bju@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

cirocosta

(whopsy)

cirocosta

It seems good to me, but the tests indicate a failure in the way we're using that flag:

docker build -t a:alpine -f ./dockerfiles/alpine/Dockerfile .

leads to


• Failure [0.425 seconds]
Out
/go/src/github.com/concourse/docker-image-resource/tests/out_test.go:18
  when cache_from images are specified
  /go/src/github.com/concourse/docker-image-resource/tests/out_test.go:575
    passes the arguments correctly to the docker build command [It]
    /go/src/github.com/concourse/docker-image-resource/tests/out_test.go:631

    Got stuck at:
        timeout: unrecognized option: t
        BusyBox v1.30.1 (2019-02-16 10:01:46 UTC) multi-call binary.

        Usage: timeout [-s SIG] SECS PROG ARGS

        Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
        Default SIG: TERM.
        Docker failed to start within 120 seconds.
        cat: can't open '/tmp/docker.pid': No such file or directory

    Waiting for:
        DOCKER ARG: --cache-from

chenbh · 2019-03-19T14:17:26Z

pulled new version of alpine:edge and ...

$ docker run -it alpine:edge
/ # timeout --help
BusyBox v1.30.1 (2019-02-16 10:01:46 UTC) multi-call binary.

Usage: timeout [-s SIG] SECS PROG ARGS

Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
Default SIG: TERM.

Before:

BusyBox v1.29.3 (2019-01-24 07:45:07 UTC) multi-call binary.

Usage: timeout [-t SECS] [-s SIG] PROG ARGS

Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
Defaults: SECS: 10, SIG: TERM.

Good old busybox version bumps

- busybox 1.30.x `timeout` uses same arg pattern as coreutils `timeout` Signed-off-by: Bin Ju <bju@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

cirocosta · 2019-03-19T17:06:47Z

Hey, I still have problems here from a clean environment (no images & from a fresh clone):

• Failure [0.490 seconds]
Out
/go/src/github.com/concourse/docker-image-resource/tests/out_test.go:18
  when build arguments contain envvars
  /go/src/github.com/concourse/docker-image-resource/tests/out_test.go:200
    expands envvars and passes the arguments correctly to the docker daemon [It]
    /go/src/github.com/concourse/docker-image-resource/tests/out_test.go:201

    Got stuck at:
        timeout: unrecognized option: t
        BusyBox v1.30.1 (2019-02-16 10:01:46 UTC) multi-call binary.

        Usage: timeout [-s SIG] SECS PROG ARGS

        Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
        Default SIG: TERM.
        Docker failed to start within 120 seconds.
        cat: can't open '/tmp/docker.pid': No such file or directory

    Waiting for:
        DOCKER ARG: --build-arg

cirocosta

Tests still showing some problems related to timeouts

chenbh · 2019-03-20T17:50:20Z

Worked with @cirocosta and it seemed to be a flake

cirocosta

SGTM

chenbh added 2 commits February 11, 2019 12:20

switch to ubuntu:bionic for base image

4968448

* resolve compatibility issue between busybox vs coreutil `timeout` Signed-off-by: Bohan Chen <bochen@pivotal.io>

newer versions of docker are hosted on their repo

06e79ef

The ubuntu package `docker` is outdated and we should be using `docker-ce` instead Signed-off-by: Bohan Chen <bochen@pivotal.io>

cirocosta mentioned this pull request Feb 11, 2019

Move Concourse resource base images to Bionic concourse/concourse#3266

Closed

77 tasks

chenbh changed the title ~~switch to ubuntu:bionic for base image~~ wip: switch to ubuntu:bionic for base image Feb 11, 2019

moving dockerfiles to a separate folder

feb21a5

Signed-off-by: Bishoy Youssef <byoussef@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

chenbh mentioned this pull request Feb 22, 2019

build both alpine and ubuntu resources concourse/concourse#3364

Merged

chenbh changed the title ~~wip: switch to ubuntu:bionic for base image~~ switch to ubuntu:bionic for base image Feb 22, 2019

cirocosta suggested changes Mar 14, 2019

View reviewed changes

assets/common.sh Show resolved Hide resolved

pivotal-bin-ju and others added 2 commits March 18, 2019 17:33

update README to reference new dockerfiles

9ed7aad

Signed-off-by: Bin Ju <bju@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

chenbh requested a review from cirocosta March 18, 2019 21:37

cirocosta approved these changes Mar 19, 2019

View reviewed changes

cirocosta suggested changes Mar 19, 2019

View reviewed changes

revert change to shell script

36b38c8

- busybox 1.30.x `timeout` uses same arg pattern as coreutils `timeout` Signed-off-by: Bin Ju <bju@pivotal.io> Co-authored-by: Bohan Chen <bochen@pivotal.io>

chenbh requested a review from cirocosta March 19, 2019 14:34

cirocosta suggested changes Mar 19, 2019

View reviewed changes

chenbh requested a review from cirocosta March 20, 2019 17:50

cirocosta approved these changes Mar 25, 2019

View reviewed changes

cirocosta merged commit 9bb78ff into master Mar 26, 2019

cirocosta deleted the bionic-base-image branch March 26, 2019 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to ubuntu:bionic for base image #256

switch to ubuntu:bionic for base image #256

chenbh commented Feb 11, 2019 •

edited

Loading

cirocosta left a comment

cirocosta left a comment •

edited

Loading

cirocosta left a comment

chenbh commented Mar 19, 2019 •

edited

Loading

cirocosta commented Mar 19, 2019 •

edited

Loading

cirocosta left a comment

chenbh commented Mar 20, 2019

cirocosta left a comment

switch to ubuntu:bionic for base image #256

switch to ubuntu:bionic for base image #256

Conversation

chenbh commented Feb 11, 2019 • edited Loading

cirocosta left a comment

Choose a reason for hiding this comment

cirocosta left a comment • edited Loading

Choose a reason for hiding this comment

cirocosta left a comment

Choose a reason for hiding this comment

chenbh commented Mar 19, 2019 • edited Loading

cirocosta commented Mar 19, 2019 • edited Loading

cirocosta left a comment

Choose a reason for hiding this comment

chenbh commented Mar 20, 2019

cirocosta left a comment

Choose a reason for hiding this comment

chenbh commented Feb 11, 2019 •

edited

Loading

cirocosta left a comment •

edited

Loading

chenbh commented Mar 19, 2019 •

edited

Loading

cirocosta commented Mar 19, 2019 •

edited

Loading