Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: valid identifiers #40

Open
wants to merge 5 commits into
base: master
from
Open

RFC: valid identifiers #40

wants to merge 5 commits into from

Conversation

@vito
Copy link
Member

vito commented Nov 13, 2019

Rendered

Prior discussion: concourse/concourse#3985

vito added 2 commits Nov 13, 2019
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
The decision to allow '.' feels somewhat arbitrary but I feel is easily
justifiable from the standpoint that it is often used for CI/CD related
things like version numbers or a DNS name identifying a deploy target.
It is also one of the few allowable special characters that does not
require any additional URL encoding.

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>

# Open Questions

* Do we want to support a 'display name'?

This comment has been minimized.

Copy link
@ari-becker

ari-becker Nov 14, 2019

For my personal circumstance, I don't need this; however, supporting a display name is probably a requirement to provide an upgrade path for a lot of users. People get attached to their personal preferences and you risk admins facing internal political wrath in their organizations over minor quibbles like this.

040-valid-identifiers/proposal.md Outdated Show resolved Hide resolved
vito added 3 commits Nov 14, 2019
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
@topherbullock

This comment has been minimized.

Copy link
Member

topherbullock commented Dec 12, 2019

This would break Christmas
https://twitter.com/topherbullock/status/950411039954399232

You're a mean one, Mister @vito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.