Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: valid identifiers #40
The decision to allow '.' feels somewhat arbitrary but I feel is easily justifiable from the standpoint that it is often used for CI/CD related things like version numbers or a DNS name identifying a deploy target. It is also one of the few allowable special characters that does not require any additional URL encoding. Signed-off-by: Alex Suraci <firstname.lastname@example.org>
This would break Christmas
You're a mean one, Mister @vito
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.