Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: instanced pipelines #34

Open
wants to merge 1 commit into
base: master
from

Conversation

@vito
Copy link
Member

vito commented Jul 16, 2019

Rendered

Please comment on individual lines, not at the top-level.

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
@vito vito referenced this pull request Aug 1, 2019
@vito vito marked this pull request as ready for review Oct 15, 2019
Pipelines can be configured with 'instance vars' like so:

```yaml
fly set-pipeline -p branch --instance-var branch=feature/foo

This comment has been minimized.

Copy link
@Zanadar

Zanadar Oct 17, 2019

Completely support this feature existing natively in concourse. I would like to see a file based api for this configuration too, ie fly set-pipeline -p branch --instance-var-file vars.yml.


```yaml
fly set-pipeline -p branch --instance-var branch=feature/foo
fly set-pipeline -p branch --instance-var branch=feature/bar

This comment has been minimized.

Copy link
@Zanadar

Zanadar Oct 17, 2019

I think the implicit looping of the configuration here could be supported well in a vars file api too, eg

fly set-pipeline -p branch --instance-var-file vars.yml

#! vars.yml
---
branch:
- feature/foo
- feature/bar
fly set-pipeline -p branch --instance-var branch=feature/bar
```

Instanced pipelines sharing the same name will be grouped together in the web UI.

This comment has been minimized.

Copy link
@Zanadar

Zanadar Oct 17, 2019

This is great! Some sort of hierarchical display would be awesome. https://buildpacks.ci.cf-app.com/ has lots of "instanced" pipelines we create through erb.yml craziness, and being able to visually organize them better would be super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.