Fix upload part size when disable_multipart is set
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cappyzawa <cappyzawa@yahoo.ne.jp>
|
thanks! |
jamieklassen
pushed a commit
to vmware-archive/release-notes
that referenced
this pull request
Jul 15, 2019
concourse/s3-resource#131 Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
nader-ziada
pushed a commit
to vmware-archive/release-notes
that referenced
this pull request
Jul 18, 2019
concourse/s3-resource#131 Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error occurred in my pipeline using s3-resource.
I set
disable_mutipart: truein source configuration.Before, when
deisalbe_multipartis set, upload part size is file size + 1.s3-resource/s3client.go
Line 202 in 8474109
S3 compatible provider has a minimum size of the upload part.
Amazon S3 Multipart Upload Limits - Amazon Simple Storage Service
So, if the file size is smaller than this, the upload fails.
I fixed it.
Sorry, I can't write the test for these changes.
But I confirmed that this patch works for a pipeline that has errors.