time comparison also takes year into account

[#137037149]

Signed-off-by: Clara Fu <cfu@pivotal.io>

check/check_test.go

@@ -124,6 +124,19 @@ var _ = Describe("Check", func() {
 						})
 					})
 
+					Context("when the resource was triggered last year near the end of the time frame", func() {
+						BeforeEach(func() {
+							prev = now.Add(-24 * time.Hour * 365)
+							version = &models.Version{Time: prev}
+						})
+
+						It("outputs a version containing the current time and supplied version", func() {
+							Expect(response).To(HaveLen(2))
+							Expect(response[0].Time.Unix()).To(BeNumerically("~", prev.Unix(), 1))
+							Expect(response[1].Time.Unix()).To(BeNumerically("~", time.Now().Unix(), 1))
+						})
+					})
+
 					Context("when the resource was triggered yesterday in the current time frame", func() {
 						BeforeEach(func() {
 							prev = now.Add(-24 * time.Hour)

lord/time_lord.go

@@ -33,7 +33,12 @@ func (tl TimeLord) Check(now time.Time) bool {
 			return true
 		}
 	} else {
-		if now.UTC().YearDay() > tl.PreviousTime.UTC().YearDay() {
+		if now.UTC().Year() > tl.PreviousTime.UTC().Year() {
+			return true
+		}
+
+		if now.UTC().Year() == tl.PreviousTime.UTC().Year() &&
+			now.UTC().YearDay() > tl.PreviousTime.UTC().YearDay() {
 			return true
 		}
 	}