Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Lists in the navigator #5843

Closed
1 of 4 tasks
lankaukk opened this issue Jun 5, 2024 · 0 comments · Fixed by #5866
Closed
1 of 4 tasks

Improvements to Lists in the navigator #5843

lankaukk opened this issue Jun 5, 2024 · 0 comments · Fixed by #5866
Assignees

Comments

@lankaukk
Copy link
Collaborator

lankaukk commented Jun 5, 2024

Problem:

This is not a harmonious design
Image

Solution

Implement a new design for lists cartouches in the navigator
Image

  • move the list length (and functionality for overriding it) inside the cartouche
  • stop showing the "List" text in those rows
  • use the new array icon in the cartouche
  • update the visual style of the cartouches to have a hovered state and a better selected state (which is also part of this ticket)

Cartouche Colors:

Text nodes and components:
default background: bg5, foreground: fg1
hovered background: fg8, foreground: fg1
selected background: fg6, , foreground: white

Internal Data:
default background: selectionBlue10, foreground: selectionBlue
hovered background: selectionBlue20, foreground: selectionBlue
selected background: selectionBlue, foreground: white

External Data:
default background: green10, foreground: green
hovered background: green20, foreground: green
selected background: green, foreground: white

When any cartouche is part of a selected row:
default background: whiteOpacity20, foreground: white
hovered background: whiteOpacity35, foreground: white
**Note: you will have to add these to the light.ts and dark.ts theme files:
whiteOpacity20: createUtopiColor('oklch(100% 0 0 /20%)')
whiteOpacity35: createUtopiColor('oklch(100% 0 0 /35%)')

@ruggi ruggi self-assigned this Jun 6, 2024
ruggi added a commit that referenced this issue Jun 10, 2024
**Problem:**

The navigator cartouche for list items needs some tidying up.

**Fix:**

- Remove its label
- Move the counter inside the cartouche itself
- Tweak the colors a bit

<img width="758" alt="Screenshot 2024-06-07 at 6 17 35 PM"
src="https://github.com/concrete-utopia/utopia/assets/1081051/2fa6e7d9-f046-41f2-bc21-d8512a26104f">

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Preview mode

Fixes #5843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants