Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grey out grid dimension control on unset #6169

Closed
ruggi opened this issue Aug 5, 2024 · 0 comments · Fixed by #6170
Closed

grey out grid dimension control on unset #6169

ruggi opened this issue Aug 5, 2024 · 0 comments · Fixed by #6170
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Aug 5, 2024

No description provided.

@ruggi ruggi self-assigned this Aug 5, 2024
@ruggi ruggi mentioned this issue Aug 5, 2024
Merged
ruggi added a commit that referenced this issue Aug 6, 2024
@ruggi
Grey out unset grid dimensions, graceful auto (#6170)
3c89911 
**Problem:**

Grid dimension controls for values undefined in the grid templates
should be greyed out and become active on hover.

**Fix:**

Do that, and also, handle gracefully `auto` values so that when the grid
template is set their `auto` value is respected and not replaced by
default with the calculated dimension.



https://github.com/user-attachments/assets/47dd6308-cc4c-4eed-b78a-e984211e5816



Note: there's still _plenty_ of room for improvement as far as managing
default-ish states go, this PR is just another baby step in that
direction.

Fixes #6169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grey out unset grid dimensions, graceful auto concrete-utopia/utopia
1 participant
@ruggi