Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10595 #10604

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix #10595 #10604

merged 2 commits into from
May 6, 2022

Conversation

hissy
Copy link
Contributor

@hissy hissy commented May 6, 2022

Andrew said he can't reproduce #10595 but I believe it should still happen on 9.1.0RC4.

Here's the video I've tried to install with the recent develop branch on PHP8.0

https://www.youtube.com/watch?v=V-_jNtheSzo

@aembler
Copy link
Member

aembler commented May 6, 2022

Yeah, I don't see this when installing. I see the changes here but in my local install h1 is filled in as the value of the titleFormat, presumably because h1 is the default value for that field:

@aembler aembler merged commit 51a72af into concretecms:develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants