Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero image title is broken after installation #10595

Closed
hissy opened this issue May 3, 2022 · 3 comments
Closed

Hero image title is broken after installation #10595

hissy opened this issue May 3, 2022 · 3 comments
Labels
Type:Bug Existing functionality not performing as expected.

Comments

@hissy
Copy link
Contributor

hissy commented May 3, 2022

Affected Version of Concrete CMS

9.x

Description

Screen Shot 2022-05-03 at 10 30 30

How to reproduce

Install with recent develop branch.

Possible Solution

We can now change the element of the title of hero image blocks by #10465
IMO we should fall back to h1 for backward compatibility.

Additional Context

No response

@hissy hissy added the Type:Bug Existing functionality not performing as expected. label May 3, 2022
@aembler
Copy link
Member

aembler commented May 3, 2022

Is your develop branch up to date? I may have seen this issue shortly after #10465 was merged but I haven't seen it in awhile. Just tried reinstalling develop and the Hero Image blocks have the proper title.

@hissy
Copy link
Contributor Author

hissy commented May 3, 2022

@aembler Yes, I pulled it yesterday and installed it via cli. I didn't try to find the reason, but some of the hero images are fine, others are broken

@aembler
Copy link
Member

aembler commented May 5, 2022

I cannot verify this. I just installed and cannot find an instance of this. We do fall back to h1. This is the code in the view() method.

      $this->set('titleFormat', $this->titleFormat ?? 'h1');

@aembler aembler closed this as completed May 5, 2022
hissy added a commit to hissy/concrete5 that referenced this issue May 6, 2022
@hissy hissy mentioned this issue May 6, 2022
aembler added a commit that referenced this issue May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Existing functionality not performing as expected.
Projects
None yet
Development

No branches or pull requests

2 participants