Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render jQueryUI dialog buttons in concrete5 style #7588

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Feb 19, 2019

I often use jQueryUI dialogs like this:

<div id="my-dialog">
    Contents
</div>
<script>
var $dialog = $('#my-dialog').dialog({my:options});
</script>

BTW, with this approach, there's no easy way to render the dialog buttons in the concrete5 default style.

So, what about supporting a syntax like this?

<div id="my-dialog">
    Contents
    <div class="dialog-buttons">
        <button class="btn btn-default pull-left">Cancel</button>
       <button class="btn btn-primary">Save</button>
    </div>
</div>

This is the same approach syntax used by the core when creating dialogs with $('#my-dialog').dialog();

@aembler
Copy link
Member

aembler commented Feb 22, 2019

Heck yeah – this drives me crazy about jquery UI. I will check this out soon.

@aembler aembler merged commit 8d9d243 into concretecms:develop Apr 29, 2019
@mlocati mlocati deleted the app-dialog-buttons branch April 29, 2019 17:27
acohin pushed a commit to acohin/concrete5 that referenced this pull request Feb 9, 2020
Render jQueryUI dialog buttons in concrete5 style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants