token refresh for batchspawner #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
requested changes
Mar 19, 2024
|
I wrote a thing that builds clickable links for single-file pull requests of json/toml/yaml from JSON schema... https://deathbeds.github.io/jupyak/shaver.html ... maybe could apply that here. |
|
Oh cool! Def make an issue with the idea. |
|
☝️ #968 |
|
Ohhhh woops I missed that! I bet we could do this as part of the new docs repo maybe? I'm not sure how api access would work to generate a pr though. I don't want to handle credentials. Maybe an admin command could be interesting and easier from a security perspective? Cc @jaimergp |
|
It doesn't need API access: there are URL parameters for the file name and
body, so the request comes in by normal means, and then you continue the
normal web flow to make a PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requests a token refresh for conda-forge/batchspawner-feedstock#6