Include license #4
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
| @@ -30,6 +30,7 @@ test: {} | |||
| about: | |||
| home: https://github.com/conda-forge/blas-feedstock | |||
| license: BSD 3-clause | |||
| license_file: {{ environ['RECIPE_DIR'] }}/LICENSE.txt | |||
There was a problem hiding this comment.
I guess the linter is balking at this. We have used environ successfully elsewhere. However, it has normally been in a list like test dependencies. We should raise this to the linter issue tracker. In the interim, I'm going to try and come up with something more friendly for the linter.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -30,6 +30,7 @@ test: {} | |||
| about: | |||
| home: https://github.com/conda-forge/blas-feedstock | |||
| license: BSD 3-clause | |||
| license_file: {{ RECIPE_DIR if RECIPE_DIR is defined else '' }}/LICENSE.txt | |||
There was a problem hiding this comment.
Checking if a variable is defined like this seems to work really well for the linter apparently. Just to muse on this a little bit, I can see a lot of value in having a jinja module loaded in advance by conda-smithy that mocks out a bunch of these variables using something like this.
Fixes #3
Adds the license file to the package. We need to do this because the BSD 3-Clause requires to include the license with all binary and source copies of this recipe/package.
As we are not actually changing any BLAS related package by adding more BLASes or changing the ordering of the BLASes, I think this is all we need to do as far as the stack is concerned.Edit: The above statement is incorrect as we did pin the version number of this package in recipes. See this example. Thus this would necessitate a total rebuild to include it. That being said, many of the BLAS dependent things are also missing licenses. So this would be a good opportunity to correct them too.