Boost unification #164
Merged
Boost unification #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since py35 and py36 both use the same vc version, it's not necessary to build boost-cpp in both versions. This disables py36 builds.
Disable python 3.6
MNT: Re-rendered with conda-smithy 2.0.0 [ci skip]
Remove Python headers
Fix checking for non-existence of python headers
Update ICU pin
…render_master MNT: Re-render the feedstock [ci skip]
Update to 1.64
* Boost ticket: https://svn.boost.org/trac/boost/ticket/12516 * Patch taken from upstream commit 1d86261: boostorg/serialization@1d86261
Fix missing include in boost::serialization
Update to 1.65
Update to 1.65.1
|
I added data about infixes too. Most of the devel stuff is either a CDT or a Perl package, but I guess that counts too. That said, you are right, and this is conda-forge-wide issue, not just Boost. Maybe worth discussing naming patterns separately: what our conventions are and perhaps even more importantly how to enforce them. |
3 tasks
This was referenced Sep 16, 2023
Co-authored-by: Marcel Bargull <mbargull@users.noreply.github.com>
…nda-forge-pinning 2023.09.20.07.15.04
|
We discussed the naming in the core call today, seems that everyone's fine to move forward with |
Alright, it's been almost a week, let's get this in. Thanks everyone! |
This was referenced Sep 27, 2023
Merged
Merged
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for conda-forge/boost-cpp-feedstock#137
Closes #53
Closes conda-forge/boost-cpp-feedstock#25
As discussed in that issue, this PR:
boost-cpp->libboost&boost->liboost-python(maintaining the old output names as wrappers for now)libboost(whileboost-cppstays unchanged without one)libboost-headersthat will fill the role of the run-export-lessboost-cppThe history of https://github.com/conda-forge/boost-cpp-feedstock is preserved through a merge (after some preparatory commits to reduce collisions). This makes the PR look unwieldy but the changes before the merge aren't very interesting. The upside is that this allows digging into the full archeology in one place (with the only snag that GH now resolves the PR links incorrectly).
Implementation notes:
libboostdepends onlibboost-headers, so the headers are really only packaged onceb2built tool doesn't seem to support only-build-don't-install so well, and more importantly, because we need to buildlibboost-pythonper python version.libboost&libboost-headersare built only once inbuild.sh/bld.bat(essentially the build scripts from boost-cpp), with the only substantial change that they're now "installed" into a temporary prefix from which we can then actually install the respective files into our $PREFIX per outputlibboost-pythonessentially keeps the build scripts of boost, only that we now reuse theb2that was bootstrapped during the global build phase (this now allows full cross-compilation; previously ppc was emulated here).build-py.{sh,bat}and the global build scripts, but for now I've tried to keep the changes to the respective histories to a minimum.libboost-pythonto only package dynamic libs, and add a run-export. Also, while it previously depended on the fullboost-cpp, the link-check says the libs aren't necessary, so switch to depend onlibboost-headersinstead.PTAL @conda-forge/boost @conda-forge/boost-cpp
CC @conda-forge/core