Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #8

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1750194337, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link

@conda-forge-admin please rerender

@tkralphs
Copy link
Contributor

Builds that were fine previously are now failing here. The proximal cause is that -lClp is missing from the final link line in the new build whereas it was present in the old, as can be seen in the build logs for the two:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=473851&view=logs&j=58ac6aab-c4bc-5de2-2894-98e408cc8ec9&t=933f325c-924e-533d-4d95-e93b5843ce8b&l=932

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=392992&view=logs&j=58ac6aab-c4bc-5de2-2894-98e408cc8ec9&t=933f325c-924e-533d-4d95-e93b5843ce8b&l=922

This doesn't seem to have anything to do with the changes in this PR.
My best guess is that this might be due to the patch here that, as near as I can tell, was added in between the last successful build and this one. This path would (I guess) result in Clp not being linked because Clp is not treated as a direct dependency by Cgl's configure script, which it probably should be. You can see this at the line starting here where you can see that there is no check for Clp.
It was working previously because Clp is a dependency of OsiClp and before the patch was listed under Libs in osi-clp.pc. Now it isn't. Yuck.

I think the fix is to make Clp a direct dependency of Cgl, which would not be difficult, but it means we have to push another release through. Not sure what to do with this PR now. It's probably fine, but just failing because of this unrelated issue.

@tkralphs tkralphs mentioned this pull request May 5, 2022
3 tasks
@tkralphs
Copy link
Contributor

tkralphs commented May 5, 2022

@conda-forge/arm-arch To fix some unrelated failures, I needed to make a new release of the upstream, which then caused merge conflicts here. I think I fixed those conflicts correctly and everything passes now, but I can also just request another PR be opened by adding the label bot-rerun, as suggested above. Can you advise?

@wolfv
Copy link
Member

wolfv commented May 5, 2022

Bot rerun should be totally fine

@tkralphs tkralphs added the bot-rerun Instruct the bot to retry the PR label May 5, 2022
@tkralphs
Copy link
Contributor

tkralphs commented May 5, 2022

Hmm, the bot is supposed to close this PR, but maybe it only checks for the label periodically?

@BastianZim
Copy link
Member

Yeah, takes a couple of hours.

@BastianZim
Copy link
Member

By the way, if you leave a bot PR open that has merge conflicts and no other commiter, the bot will also redo the PR.

@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/2276822402

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arch_h362fcb branch May 5, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants