zip cudnn with cuda version and cleanup #1051
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/core, this is ready |
|
Would it make sense to address this compiler constraint ( conda-forge/nvcc-feedstock#51 ) at the same time? |
That would be great. It's been a blocker for CuPy. |
|
Related: #1000 |
No, that cannot be handled with pinning like that, because adding that would add a matrix of compilers for non CUDA builds. |
|
On the other hand, if a feedstock is rerendered with This is blocking the cuda 11.0 migration, so merge? |
Just curious, where is this pinning done? |
|
Thanks @isuruf! LGTM. |
| @@ -44,6 +44,12 @@ cuda_compiler_version: | |||
| - 10.0 # [linux64] | |||
| - 10.1 # [linux64] | |||
| - 10.2 # [linux64] | |||
| cudnn: | |||
| - undefined | |||
There was a problem hiding this comment.
I think this needs to be None?
There was a problem hiding this comment.
It doesn't matter what this value is
There was a problem hiding this comment.
Doesn't matter to conda sure, it may matter to the bot however. I need to dig more.
There was a problem hiding this comment.
I can change it to None if that helps
There was a problem hiding this comment.
Thank you! I think I put in a more general fix that appears to be working.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)