Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ipython 8.22 lower pin for traitlets to 5.13 #671

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 23, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

References:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
noarch
noarch::ipython-8.22.0-pyh707e725_0.conda
noarch::ipython-8.22.0-pyh7428d3b_0.conda
-    "traitlets >=5",
+    "traitlets >=5.13",
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Thanks Nick! 🙏

Is this ready for review? Asking as it is marked as draft atm

@bollwyvl bollwyvl marked this pull request as ready for review February 23, 2024 20:18
@bollwyvl bollwyvl requested a review from a team as a code owner February 23, 2024 20:18
@bollwyvl
Copy link
Contributor Author

@jakirkham undrafted! 🏎️ 💨 🏎️

@jakirkham jakirkham merged commit e9a3d92 into conda-forge:main Feb 23, 2024
4 checks passed
@jakirkham
Copy link
Member

Thanks Nick! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants