Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipython v8.22.1 #210

Merged
merged 4 commits into from Feb 23, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection+grayskull shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection+grayskull but not in the meta.yaml:

  • setuptools >=61.2
  • jupyter_client
  • wcwidth
  • sphinx
  • docutils
  • pyglet
  • pyopengl
  • pygobject
  • traitlets >=5.13.0
  • pythonnet
  • prompt-toolkit <3.1.0,>=3.0.41
  • wxpython
  • ipyparallel

Packages found in the meta.yaml but not found by source code inspection+grayskull:

  • setuptools >=51.0.0
  • __win
  • traitlets >=5
  • typing_extensions
  • __unix
  • pickleshare
  • prompt-toolkit >=3.0.41,<3.1.0

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8007738835, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

As `pickleshare` is now optional as of `ipython` version `8.17.0`+, drop
it from required dependencies.
- prompt-toolkit >=3.0.41,<3.1.0
- pygments >=2.4.0
- stack_data
- traitlets >=5
- traitlets >=5.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated in ipython version 8.22.1 with PR: ipython/ipython#14353

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to follow up with a repodata-patches PR for .0, or the solver may random-walk to the older traitlets. I haven't done any forensics as to where this creates an issue in downstreams, but seems easy enough in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. @jakirkham, would you be able to help with this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Nick started PR: conda-forge/conda-forge-repodata-patches-feedstock#671

Would be happy to review 🙂

recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Pushed a couple requirement updates noted above

Could someone please look over these as well?

@bollwyvl
Copy link
Contributor

bollwyvl commented Feb 22, 2024 via email

@vyasr
Copy link

vyasr commented Feb 23, 2024

Are you thinking of something like this? ipython/ipython#14237

@jakirkham
Copy link
Member

I reckon we put pickleshare back in ... The failure modes are not pretty

Am ok with that. Just couldn't tell if we just forgot to drop it here or if it was intentionally left in

Would also be interested to know what the failure modes are

Has there been discussion upstream about readding pickleshare as a hard dependency?

@bollwyvl
Copy link
Contributor

Yeah, the referenced link is one of them. Basically a bunch of %%magics just fail, without saying why, didn't seem like something we wanted to deal with. Seemed pretty breaking when it landed. I haven't pushed on it upstream.

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@bollwyvl bollwyvl merged commit 89c9344 into conda-forge:main Feb 23, 2024
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 8.22.1_h886c0e branch February 23, 2024 16:55
@Carreau
Copy link
Contributor

Carreau commented Feb 26, 2024

Yeah I will probably reintroduce pickleshare as a hard dependency, but it's a dependency that is used only by IPython and I don't like it. It woudl be great to find an alternative.

1 similar comment
@Carreau
Copy link
Contributor

Carreau commented Feb 26, 2024

Yeah I will probably reintroduce pickleshare as a hard dependency, but it's a dependency that is used only by IPython and I don't like it. It woudl be great to find an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants