Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenting local runs better #1590

Merged
merged 13 commits into from Feb 1, 2022
Merged

documenting local runs better #1590

merged 13 commits into from Feb 1, 2022

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Jan 22, 2022

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@ngam ngam requested a review from a team as a code owner January 22, 2022 19:09
@ngam ngam changed the title Patch-1 documenting local runs better Jan 22, 2022
@ngam
Copy link
Contributor Author

ngam commented Jan 22, 2022

ready for review, in #1587's stead, cc @isuruf and @jakirkham

ngam and others added 2 commits January 22, 2022 15:14
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
.ci_scripts/environment.yml Outdated Show resolved Hide resolved
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an awful lot of instructions to read for a beginner. Can we port build-locally.py from a feedstock here?

@ngam
Copy link
Contributor Author

ngam commented Jan 22, 2022

build-locally.py

You mean code-wise? Yes! That'd be super neat if we have the same process in staged-recipes as the feedstocks. It makes a huge difference! It took me a long time to figure things out (granted, I am not good at reading documentation)

@isuruf
Copy link
Member

isuruf commented Jan 22, 2022

Yes, we'll have to copy build-locally.py from a feedstock and make a few changes.

@ngam
Copy link
Contributor Author

ngam commented Jan 22, 2022

Yes, we'll have to copy build-locally.py from a feedstock and make a few changes.

Above my pay grade for now (also trying to get mxnet on cf), but I can think about it later. I fully support this tho

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. I have not looked at the rest.

src/maintainer/adding_pkgs.rst Outdated Show resolved Hide resolved
@ngam
Copy link
Contributor Author

ngam commented Jan 22, 2022

Do NOT merge. This PR will be moot if this conda-forge/staged-recipes#17617 goes through.

@ngam
Copy link
Contributor Author

ngam commented Jan 24, 2022

Thanks to @isuruf's PR conda-forge/staged-recipes#17617, this is now much much simpler!

@ngam
Copy link
Contributor Author

ngam commented Jan 31, 2022

@isuruf @beckermr now that conda-forge/staged-recipes#17617 is merged, this should be reviewed and merged. Thanks!

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this build all recipes? It might be good to specify how to build just one of them if that is possible.

@ngam
Copy link
Contributor Author

ngam commented Feb 1, 2022

I believe it builds only one. So, python build-locally.py will simply prompt you to choose from a list and python build-locally.py linux64 will bypass that prompt and build the linux64 configuration.

@beckermr
Copy link
Member

beckermr commented Feb 1, 2022

I meant the recipes not the platforms. I've asked a question on the stages recipes pr. We are good to merge this for now and we can clarify it later. Thank you!

@beckermr beckermr merged commit 0403f82 into conda-forge:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants