New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documenting local runs better #1590
Conversation
ready for review, in #1587's stead, cc @isuruf and @jakirkham |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an awful lot of instructions to read for a beginner. Can we port build-locally.py
from a feedstock here?
You mean code-wise? Yes! That'd be super neat if we have the same process in staged-recipes as the feedstocks. It makes a huge difference! It took me a long time to figure things out (granted, I am not good at reading documentation) |
Yes, we'll have to copy |
Above my pay grade for now (also trying to get mxnet on cf), but I can think about it later. I fully support this tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above. I have not looked at the rest.
Do NOT merge. This PR will be moot if this conda-forge/staged-recipes#17617 goes through. |
Thanks to @isuruf's PR conda-forge/staged-recipes#17617, this is now much much simpler! |
@isuruf @beckermr now that conda-forge/staged-recipes#17617 is merged, this should be reviewed and merged. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this build all recipes? It might be good to specify how to build just one of them if that is possible.
I believe it builds only one. So, |
I meant the recipes not the platforms. I've asked a question on the stages recipes pr. We are good to merge this for now and we can clarify it later. Thank you! |
PR Checklist:
src
directory, not indocs
or in the html files