Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Element rooms' links #1937

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Added Element rooms' links #1937

merged 6 commits into from
Apr 19, 2023

Conversation

mhmohona
Copy link
Contributor

Fixes - #1677
Added info about element rooms for Get in touch page.

@mhmohona mhmohona requested a review from a team as a code owner April 19, 2023 06:11
beckermr
beckermr requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! All gitter rooms are available from element now. They are actually one and the same. I think we'll need to adjust the PR to somehow reflect this.

src/orga/getting-in-touch.rst Outdated Show resolved Hide resolved
src/orga/getting-in-touch.rst Outdated Show resolved Hide resolved
@mhmohona mhmohona requested a review from beckermr April 19, 2023 11:15
jakirkham
jakirkham reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this?

src/orga/getting-in-touch.rst Show resolved Hide resolved
@beckermr @jakirkham
Update src/orga/getting-in-touch.rst
a7a4bee 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@beckermr beckermr enabled auto-merge April 19, 2023 16:45
beckermr
beckermr reviewed Apr 19, 2023
View reviewed changes
src/conf.py Outdated Show resolved Hide resolved
@beckermr beckermr merged commit 2d27a2f into conda-forge:main Apr 19, 2023
@jakirkham
Copy link
Member

Thanks Mahfuza & Matt! 🙏

@mhmohona mhmohona deleted the Adding-element branch April 20, 2023 03:30
@jaimergp
Copy link
Member

There are a few more instances of Gitter being mentioned which, I believe, should be replaced by Element/Matrix to avoid confusion.

See this search query.

It might be worth considering opening a 2nd PR as a follow-up!

@mhmohona mhmohona mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhmohona @jakirkham @jaimergp @beckermr