Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of role of infrastructure in package building #2150

Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Apr 12, 2024

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

This adds a brief description of what role the infrastructure plays in packaging.

Co-authored-by: Klaus Zimmermann <klaus.zimmermann@quansight.com>

Fix link in interaction

Remove reference to unwritten section
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 12e02ab
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/66217bc97b4f17000807f724
😎 Deploy Preview https://deploy-preview-2150--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp jaimergp added the Docs label Apr 12, 2024
@zklaus zklaus marked this pull request as ready for review April 12, 2024 16:04
@zklaus zklaus requested a review from a team as a code owner April 12, 2024 16:04
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do conda-forge-linter -> conda-forge-admin everywhere, but otherwise LGTM.

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to clarify some recent updates.

docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
docs/maintainer/infrastructure.md Show resolved Hide resolved
docs/maintainer/infrastructure.md Outdated Show resolved Hide resolved
@beckermr
Copy link
Member

pre-commit.ci autofix

@zklaus
Copy link
Contributor Author

zklaus commented Apr 18, 2024

pre-commit.ci autofix

@beckermr beckermr merged commit f5e9177 into conda-forge:main Apr 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants