Add a note about conda-forge/staged-recipes#6167 #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdill
requested changes
Jul 22, 2019
src/maintainer/adding_pkgs.rst
Outdated
| before starting the process over with the next recipe in the chain. | ||
| the builds finish in the dependencies order. Note that due to a bug in that script, | ||
| only simple PRs will pass and it is recommended to split the recipes into multiple | ||
| PRs in that case. |
There was a problem hiding this comment.
Generally 👍 on adding this, though given the suggested flow, it feels a bit out of order. I'd suggest moving this sentence to a warning below and leaving the "Using a single pull request..." sentence in place. Something like this:
.. warning::
Due to a [bug](https://github.com/conda-forge/staged-recipes/issues/6167) in the script that builds the packages on staged-recipes
pull-requests, some complex multi-package pull-requests will fail and,
if this happens, it is recommended to split the single pull-request into
multiple pull-requests
Co-authored-by: Isuru Fernando <isuruf@gmail.com> Co-authored-by: Eric Dill <ericdill@users.noreply.github.com>
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Rebased and updated for Docusaurus assuming that this still happening (referred issue is still open, linked conda issue there was closed as stale, not solved). I added @ericdill's suggestion too. |
beckermr
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until conda-forge/staged-recipes#6167 is fixed