Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add new lines directly after new content #1400

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

jwillemsen
Copy link
Contributor

* conda_smithy/templates/README.md.tmpl:

    * conda_smithy/templates/README.md.tmpl:
@isuruf
Copy link
Member

isuruf commented Oct 5, 2020

I don't see how this changes anything

    * conda_smithy/templates/README.md.tmpl:
    * conda_smithy/templates/README.md.tmpl:
    * conda_smithy/templates/README.md.tmpl:
    * conda_smithy/templates/README.md.tmpl:
@jwillemsen jwillemsen closed this Oct 6, 2020
@jakirkham
Copy link
Member

Yeah I think this is just a matter of adding some - probably in the endif. There's a little bit of fiddling to get this sort of thing right. Fortunately the space of parameters to explore is quite small 🙂

    * conda_smithy/templates/README.md.tmpl:
@jwillemsen
Copy link
Contributor Author

jwillemsen commented Oct 6, 2020

Ok, now it works, no double blank lines

@jwillemsen jwillemsen reopened this Oct 6, 2020
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@isuruf isuruf merged commit 1e3c16f into conda-forge:master Oct 6, 2020
@jakirkham
Copy link
Member

Thanks Johnny! Know fiddling with Jinja whitespace is a little tedious. We appreciate the effort 🙂

@jwillemsen
Copy link
Contributor Author

Yes, sorting this out took some time, it doesn't work as I thought it works. This is my last change for conda-smithy, just wanted to assist a user with packaging ACE through conda, now back to my real work ;-)

@jwillemsen jwillemsen deleted the jwi-devdocsummarylayout branch October 7, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants