check up-to-date with not broken versions only #1849
Conversation
conda_smithy/configure_feedstock.py
Outdated
| @@ -2188,17 +2188,17 @@ def _load_forge_config(forge_dir, exclusive_config_file, forge_yml=None): | |||
| return config | |||
|
|
|||
|
|
|||
| def get_most_recent_version(name): | |||
| def get_most_recent_version(name, only_not_broken=False): | |||
There was a problem hiding this comment.
Shouldn't this be the unconditional default, i.e. not add another parameter?
There was a problem hiding this comment.
At a minimum, think the default value should be True. Choosing to include broken packages should be opt-in (as it is with installing them)
There was a problem hiding this comment.
Ok, changed the kwarg to include_broken=False.
|
Thanks Jaime! 🙏 Agree with others on the line above Otherwise think this is a welcome improvement. Thanks again for putting it together 🙂 |
|
The |
|
Should we move that to an issue so we don't forget? |
Done. |
Checklist
newsentryCloses #1848