Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require C & C++ compilers in cuda-nvcc #21

Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jun 27, 2023

As the cuda-nvcc package is intended for usage by developers in their environments and having working C & C++ compilers is a prerequisite, simply make the C & C++ compilers requirements of cuda-nvcc.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As the `cuda-nvcc` package is intended for usage by developers in their
environments and having working C & C++ compilers is a prerequisite,
simply make the C & C++ compilers requirements of `cuda-nvcc`.
@jakirkham jakirkham requested a review from adibbley as a code owner June 27, 2023 21:41
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the cuda-nvcc_req_compilers branch of jakirkham-feedstocks/cuda-nvcc-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvcc-feedstock/actions/runs/5394898787.

@jakirkham
Copy link
Member Author

jakirkham commented Jun 27, 2023

Not seeing any changes when re-rendering locally 😕

Edit: Though wouldn't expect to necessarily. Unclear why the bot reached a different conclusion

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to keep this warning, or can that be removed now that the compilers are hard dependencies?

echo 'cuda-nvcc: Please add the `compiler("c")` and `compiler("cxx")` packages to the environment.'

@jakirkham
Copy link
Member Author

Think so because the activation scripts are part of cuda-nvcc_{{ cross_target_platform }}

- name: cuda-nvcc_{{ cross_target_platform }}
run_exports:
strong:
- cuda-version >={{ cuda_version }},<{{ cuda_version.split(".")[0]|int + 1 }}
files:
- etc/conda/activate.d/~cuda-nvcc_activate.sh # [linux]
- etc/conda/deactivate.d/~cuda-nvcc_deactivate.sh # [linux]

@adibbley adibbley merged commit df7b04f into conda-forge:main Jun 27, 2023
6 checks passed
@jakirkham jakirkham deleted the cuda-nvcc_req_compilers branch June 27, 2023 22:52
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Comment on lines 26 to 27
- {{ compiler('c') }}
- {{ compiler('cxx') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to do {{ c_compiler }} instead to avoid pinning a version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! 🙏

Yeah that seems reasonable

Should we do the same thing in the compilers-feedstock?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The purpose of compilers feedstock is to give the users the same compilers used by conda-build, whereas cuda-nvcc is a way to give users nvcc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we would like one that plays well with the same compilers conda-build uses. So maybe it is not that far off

What if we did this?

Suggested change
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- c-compiler
- cxx-compiler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to update this thread, as cuda-compiler fills a similar purpose to c-compiler & cxx-compiler (and includes them as dependencies), think Isuru's original suggestion is probably the best choice here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants