-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require C & C++ compilers in cuda-nvcc
#21
Require C & C++ compilers in cuda-nvcc
#21
Conversation
As the `cuda-nvcc` package is intended for usage by developers in their environments and having working C & C++ compilers is a prerequisite, simply make the C & C++ compilers requirements of `cuda-nvcc`.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the cuda-nvcc_req_compilers branch of jakirkham-feedstocks/cuda-nvcc-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvcc-feedstock/actions/runs/5394898787. |
Not seeing any changes when re-rendering locally 😕 Edit: Though wouldn't expect to necessarily. Unclear why the bot reached a different conclusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep this warning, or can that be removed now that the compilers are hard dependencies?
cuda-nvcc-feedstock/recipe/activate.sh
Line 31 in f602ed9
echo 'cuda-nvcc: Please add the `compiler("c")` and `compiler("cxx")` packages to the environment.' |
Think so because the activation scripts are part of cuda-nvcc-feedstock/recipe/meta.yaml Lines 43 to 49 in f602ed9
|
Thanks all! 🙏 |
- {{ compiler('c') }} | ||
- {{ compiler('cxx') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to do {{ c_compiler }}
instead to avoid pinning a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! 🙏
Yeah that seems reasonable
Should we do the same thing in the compilers-feedstock
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. The purpose of compilers
feedstock is to give the users the same compilers used by conda-build, whereas cuda-nvcc
is a way to give users nvcc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though we would like one that plays well with the same compilers conda-build uses. So maybe it is not that far off
What if we did this?
- {{ compiler('c') }} | |
- {{ compiler('cxx') }} | |
- c-compiler | |
- cxx-compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to update this thread, as cuda-compiler
fills a similar purpose to c-compiler
& cxx-compiler
(and includes them as dependencies), think Isuru's original suggestion is probably the best choice here
As the
cuda-nvcc
package is intended for usage by developers in their environments and having working C & C++ compilers is a prerequisite, simply make the C & C++ compilers requirements ofcuda-nvcc
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)