Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require C & C++ compilers in cuda-nvcc #21

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Require C & C++ compilers in cuda-nvcc #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dcc56b
Require C & C++ compilers in `cuda-nvcc`
jakirkham Jun 27, 2023
e1d12cb
Bump `build/number` to `7`
jakirkham Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ source:
sha256: 5db25d4fd138013b563f9a3d1d87f7de7df1dac014fd4cccdfbb3435a5cff761

build:
number: 6
number: 7
skip: true # [osx or win]
skip: true # [target_platform != "linux-64" and target_platform != cross_target_platform]

Expand All @@ -23,10 +23,9 @@ outputs:
requirements:
run:
- cuda-nvcc_{{ target_platform }} {{ version }}.*
test:
requires:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
Comment on lines 26 to 27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to do {{ c_compiler }} instead to avoid pinning a version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! 🙏

Yeah that seems reasonable

Should we do the same thing in the compilers-feedstock?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The purpose of compilers feedstock is to give the users the same compilers used by conda-build, whereas cuda-nvcc is a way to give users nvcc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we would like one that plays well with the same compilers conda-build uses. So maybe it is not that far off

What if we did this?

Suggested change
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- c-compiler
- cxx-compiler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to update this thread, as cuda-compiler fills a similar purpose to c-compiler & cxx-compiler (and includes them as dependencies), think Isuru's original suggestion is probably the best choice here

test:
commands:
- test -f $PREFIX/bin/nvcc # [linux]
- if not exist %LIBRARY_BIN%\nvcc.exe exit 1 # [win]
Expand Down