Fixes for macOS #28
Merged
Fixes for macOS #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Needed to actually get the linkages to libssh2 right. Otherwise it fails when trying to load dependent libraries.
The new recipe tests included things like hard coding `.so` and using `ldd` on macOS, which can't possibly work. This tidies those tests up to work (or be skipped) on macOS as appropriate while still working on Linux.
The 2056 and 2057 tests fail on macOS and are known to fail upstream. For now just patch them out so the build can proceed without them.
Some compiler flags changed on Linux, but doubt that has any real effect. Since macOS failed to deploy anyways there is no conflict with build number 0. Still, to be cautious, bump the build number to 1.
jakirkham
commented
Mar 16, 2018
| # # | ||
| # xref: https://github.com/curl/curl/issues/2394 # | ||
| ################################################### | ||
| - drop_failing_tests_macos.diff # [osx] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches out some broken tests on macOS that are known to fail upstream. The fix for these failures are pending. Also adjusts the new recipe tests to be compatible or skipped (e.g.
ldd) as appropriate on macOS. Fixes a linkage issue withlibssh2that was causing the build to break locally.