Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #9

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Jun 1, 2023

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5144410809, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Seeing the following error on CI:

CMake Error at CMakeLists.txt:218 (target_link_libraries):
  Target "CyRSoXS" links to:

    CUDA::cufft

  but the target was not found.

As the new CUDA 12 packages split all these components up ( conda-forge/staged-recipes#21382 ), think we need to add libcufft-dev to host:

  host:
    - libcufft-dev      # [(cuda_compiler_version or "").startswith("12")]

Note that *-dev suffixed packages have headers and dynamic libraries. They add the * package (no -dev suffix) to run automatically via run_exports

Edit: For more info about the CUDA 12 bringup, please see issue ( conda-forge/conda-forge.github.io#1963 )

@pbeaucage
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Attempted to resolve the conflicts with the merge commit above

@pbeaucage
Copy link
Contributor

Thanks, that worked, it's unfortunately back to the same issue. I believe this is a nvcc bug on some "creative" syntax used in pybind11, see pybind/pybind11#4606 . Appears that the nvcc team has an internal bug for this issue and it should be fixed in a future release. I don't think it makes sense for us to try to patch this, we can just wait for upstream fixes.

The combination of pybind11 + GCC 12 + nvcc 12 runs into compilation
errors. This is documented in a pybind11 issue. To workaround this,
configure the CUDA 12 migrator to use GCC 11, which shouldn't have this
issue.

xref: pybind/pybind11#4606
@jakirkham
Copy link
Member

Yeah noticed that issue recently

Have had some success using GCC 11 instead ( conda-forge/pp-sketchlib-feedstock#40 )

Tried pushing similar changes here

@jakirkham
Copy link
Member

jakirkham commented Jun 27, 2023

Looks like that got past the compilation issue and the build completed 🎉

Now seeing this failure in the test phase on CI

import: 'CyRSoXS'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/cyrsoxs_1687903533456/test_tmp/run_test.py", line 2, in <module>
    import CyRSoXS
ImportError: libnppig.so.12: ELF load command address/offset not properly aligned

Looks like the libraries in libnpp are getting corrupted somehow ( conda-forge/libnpp-feedstock#2 )

@pbeaucage
Copy link
Contributor

@conda-forge-admin, please rerender

@jakirkham jakirkham added the bot-rerun Instruct the bot to retry the PR label Aug 24, 2023
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/5961825690

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_h01b6f6 branch August 24, 2023 09:18
@jakirkham
Copy link
Member

Superseded by PR: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants