Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno v1.35.0 #56

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #54
Closes: #55

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5460465386, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mdekstrand
Copy link
Contributor

Checking in on the status of this. OSX failed, but that looks like it might be transient; restarted those builds.

Windows is still having the FFI problem from #54. I can successfully build libffi-sys on my machine. I'm going to try a local Conda build this week and see if that scares up the problem.

@mdekstrand
Copy link
Contributor

The OSX failures were indeed ephemeral, so all that's left is libffi.

@mdekstrand
Copy link
Contributor

good news!

libffi-sys fails to build on my local machine in a conda build.

@mdekstrand
Copy link
Contributor

Incredibly ugly hack - I added a patch to make Deno patch libffi-sys with a version that fixes the build problem. tov/libffi-rs#79 tracks the root cause.

@cscheid
Copy link
Contributor

cscheid commented Jul 7, 2023

I think hacks are totally fine here and we should merge; I just wonder how this can bite us. It looks like we won't error out early. Does that mean an installation might think it succeeded but didn't? Hopefully this is obvious enough to not matter.

@cscheid cscheid merged commit 6589332 into conda-forge:main Jul 7, 2023
7 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.35.0_h822e19 branch July 7, 2023 12:57
@mdekstrand
Copy link
Contributor

I think the installation shouldn't falsely think it succeeded - it actually used to before this PR (it failed to build, and then tried to test and failed there), the error level checks fix that problem.

I'm going to submit a PR to libffi-rs to fix the build bug there, so hopefully once Deno has updated its deps we can drop the patch and go back to normal.

@cscheid
Copy link
Contributor

cscheid commented Jul 7, 2023

Yeah, I definitely think we're safe here. I'm just documenting my thought process at the time in case it goes wrong a few days from now, when I'll have zero recollection I ever looked at this 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants