-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2023.2.1 #242
Release 2023.2.1 #242
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/distributed-feedstock/actions/runs/4265949970. |
@@ -28,7 +28,7 @@ requirements: | |||
- python >=3.8 | |||
- click >=7.0 | |||
- cloudpickle >=1.5.0 | |||
- cytoolz >=0.10.0 | |||
- cytoolz >=0.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this was a change made with dask/distributed#7285 that we missed in the 2023.1.0 release? cc @jrbourbeau @jakirkham just making sure that leaving this at >=0.10.0
wasn't intentional in the past few releases.
Shouldn't be difficult to submit a repodata patch to update this for the impacted versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the toolz
version in requirements.txt
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not immediately obvious to me? It doesn't look like there's a package for toolz
0.10.1 available on either PyPI or conda-forge, and it looks like Distributed's mindeps testing is currently running without issues pinned to 0.10.0 (though not sure if this is case where installing cytoolz
in the same environment would override this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Yeah guess 0.11.0
is the next version where they are aligned. So sounds like we leave toolz
alone
@conda-forge-admin, please restart CI |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)