Update qemu-user-static to version 8.0.4 #246
Conversation
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
The runner apparently doesn't have bsdtar installed. Let's just use dpkg-deb to extract Debian packages instead then. Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
| @@ -1,33 +1,43 @@ | |||
| #!/bin/bash -ex | |||
|
|
|||
| set -xe | |||
| set -eux | |||
|
|
|||
| if [ "$(uname -m)" == "x86_64" ]; then | |||
| docker run --rm --privileged multiarch/qemu-user-static:register --reset | |||
There was a problem hiding this comment.
N.B.: We can leave this as is since the binfmt_misc registration will be the same for any version.
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
This can just live on in Git commit history instead of cluttering code. Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
|
So, the from the I skimmed over https://gitlab.com/qemu-project/qemu/-/issues/?sort=created_date&state=all&label_name%5B%5D=target%3A%20arm but nothing jumped at me immediately (didn't look too long). All other tried versions --
|
The build for linux-anvil-aarch64 stalled with 8.1.2 from Debian. ref: conda-forge#246 (comment) Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
mbargull
changed the title
|
Thanks for the investigation!
IMO option 1 sounds preferable. If QEMU 8 already solves the issues we see with numpy, scipy - all the better! If not, we can always try updating again later (whether to 8.1.3, 8.2.0, or some future version). |
Then this only needs an approving review and we can merge ;). |
| curl -sL \ | ||
| "https://mirrors.edge.kernel.org/ubuntu/pool/universe/q/qemu/qemu-user-static_${version}%2B${build}_amd64.deb" | | ||
| dpkg-deb --extract - ./deb-tmp | ||
| mv ./deb-tmp/usr/bin/qemu-*-static ./ |
There was a problem hiding this comment.
Are we not moving too many aarches here? I don't know how many come with the deb file, but the fact that we could remove arm and things still work sounds to me like we're blowing up the image unnecessarily here?
Perhaps it's better to go back to an explicit for-loop?
There was a problem hiding this comment.
Doesn't really hurt since only those that we explicitly ADD/COPY in the build files get used.
(It's similar to having the .git directory in the build context -- it's there, but we don't care since we don't touch it.)
Even the temporary directory and moving those files isn't really necessary.
I.e., we could just dpkg-deb --extract - ./qemu-user-static and then COPY ./qemu-user-static/usr/bin/qemu-aarch64-static /usr/bin/ in the Dockerfiles.
(I just didn't do that yet since I didn't want to argue for or against it.)
There was a problem hiding this comment.
Thanks. I was thinking this would be called during the docker build, but if it's just happening in the build context, then obviously that's not an issue.
I.e., we could just
dpkg-deb --extract - ./qemu-user-staticand thenCOPY ./qemu-user-static/usr/bin/qemu-aarch64-static /usr/bin/in theDockerfiles.
(I just didn't do that yet since I didn't want to argue for or against it.)
That could be a nice improvement IMO.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)closes gh-245
closes gh-228
The GitHub repo we pulled the binaries from before is not updated as mentioned by @h-vetinari in #245 (comment) .
This now downloads the binaries from Fedora (or Debian).