Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for PyPy3.9 #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8011780124, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lgray lgray added the automerge Merge the PR when CI passes label Feb 22, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@matthewfeickert matthewfeickert mentioned this pull request Feb 23, 2024
3 tasks
@matthewfeickert
Copy link
Member

From the PyPy error logs:

import: 'fastjet'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/test_tmp/run_test.py", line 2, in <module>
    import fastjet
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py", line 8, in <module>
    import fastjet._pyjet  # noqa: F401, E402
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/_pyjet.py", line 7, in <module>
    from fastjet.__init__ import ClusterSequence
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py", line 9, in <module>
    import fastjet._swig  # noqa: F401, E402
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/_swig.py", line 65, in <module>
    from . import _fastjet
ImportError: cannot import name '_fastjet' from partially initialized module 'fastjet' (most likely due to a circular import) (/home/conda/feedstock_root/build_artifacts/fastjet_1708645257057/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py)

I'm not sure why PyPy cares about this by CPython doesn't. :?

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 25, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@matthewfeickert
Copy link
Member

Hm, the errors in CI

import: 'fastjet'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/test_tmp/run_test.py", line 2, in <module>
    import fastjet
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py", line 8, in <module>
    import fastjet._pyjet  # noqa: F401, E402
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/_pyjet.py", line 7, in <module>
    from fastjet.__init__ import ClusterSequence
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py", line 9, in <module>
    import fastjet._swig  # noqa: F401, E402
  File "/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/_swig.py", line 65, in <module>
    from . import _fastjet
ImportError: cannot import name '_fastjet' from partially initialized module 'fastjet' (most likely due to a circular import) (/home/conda/feedstock_root/build_artifacts/fastjet_1708879646740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/pypy3.9/site-packages/fastjet/__init__.py)
WARNING: Tests failed for fastjet-3.4.0.6-py39hbb5549f_4.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: fastjet-3.4.0.6-py39hbb5549f_4.conda

are locally reproducible in a pypy:3.10 Docker container

(venv) root@6303fb065633:/fastjet# python -c 'import fastjet'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/venv/lib/pypy3.10/site-packages/fastjet/__init__.py", line 8, in <module>
    import fastjet._pyjet  # noqa: F401, E402
    ^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/pypy3.10/site-packages/fastjet/_pyjet.py", line 7, in <module>
    from fastjet.__init__ import ClusterSequence
  File "/venv/lib/pypy3.10/site-packages/fastjet/__init__.py", line 9, in <module>
    import fastjet._swig  # noqa: F401, E402
    ^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/pypy3.10/site-packages/fastjet/_swig.py", line 68, in <module>
    from . import _fastjet
ImportError: cannot import name '_fastjet' from partially initialized module 'fastjet' (most likely due to a circular import) (/venv/lib/pypy3.10/site-packages/fastjet/__init__.py)

Which makes it seem like for PyPy to work this is going to require some upstream fixes in the current https://github.com/scikit-hep/fastjet that we'll have to patch back here for these older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants