Migrate to Jinja2 compiler syntax #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
reviewed
Jul 3, 2018
recipe/meta.yaml
Outdated
| - perl 5.22.2.1 # [not win] | ||
| - cmake # [win] | ||
| - {{ compiler('fortran') }} |
There was a problem hiding this comment.
Hmm...seems to have incorrectly assumed fortran. We are not currently supporting that AFAIK.
There was a problem hiding this comment.
This causes a build failure on Windows.
ref: https://ci.appveyor.com/project/conda-forge/fftw-feedstock/build/1.0.54/job/r4v1pyx3xum259ss
jakirkham
reviewed
Jul 3, 2018
recipe/meta.yaml
Outdated
|
|
||
| requirements: | ||
| build: | ||
| - python # [win] | ||
| - toolchain | ||
| - perl 5.22.2.1 # [not win] |
There was a problem hiding this comment.
This should be relaxed to perl.
This was referenced Jul 3, 2018
This doesn't work for VC9. Plus we are not using it currently. So just drop it.
Now that the Fortran compiler is not used, re-render to drop it from the variants.
There was only a need to pin `perl` to workaround some issues with older `conda-build`s. This issue is not relevant for newer `conda-build`s (particularly when `perl` is in `build` not `host`).
Now that the `perl` pinning is dropped, re-render to update the variants. This effectively adds a lower bound for `perl`.
This was only needed to align `vc` during testing on Windows. However it is no longer needed with `conda-build` 3, so drop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes done to the recipe:
Renamed build with host
Moving
python # [win]which was used for vc matrixRemoving toolchain in favour of compiler()
Moving perl from host to build
Moving cmake from host to build
Removed skip for one of py35 or py36 as it's used for vc skipping
Removing vc features
Removing features section as it is empty
Adding Fortran compiler
Adding C compiler
If you have recived a
Migrate to Jinja2 compiler syntaxPR from me recently please close that one and use this one.It is very likely that this feedstock is in need of migration.
Notes and instructions for merging this PR:
This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever) and pip (pip install re-ver) installable.Finally, feel free to drop us a line if there are any issues!