Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gepetto-viewer-corba v5.8.0 #22

Merged
merged 2 commits into from
May 2, 2024

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
qt-main 6.2.4 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • urdf-parser-py
  • numpy
  • ros-roslib
  • docutils
  • omniorb
  • cython
  • sphinx
  • pyyaml
  • pygments

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8498255197, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

There's some mismatch happening here:

    omniorb:                   4.3.2-py310hc61f13b_2      conda-forge
    omniorb-libs:              4.3.2-h4514ac0_2           conda-forge
    omniorbpy:                 4.3.1-py310h546aac4_0      conda-forge

@conda-forge/omniorb it seems the metadata is not sufficiently constrained, i.e. the run-export of omniorb needs to go down to the patch level ('x.x.x') instead of just the minor version. Aside from that, merging conda-forge/omniorb-feedstock#48 (CC @beenje) should normally happen in sync with an an update for omniorbpy.

@beenje
Copy link

beenje commented Apr 29, 2024

@conda-forge/omniorb it seems the metadata is not sufficiently constrained, i.e. the run-export of omniorb needs to go down to the patch level ('x.x.x') instead of just the minor version. Aside from that, merging conda-forge/omniorb-feedstock#48 (CC @beenje) should normally happen in sync with an an update for omniorbpy.

Sorry, I don't use omniorbpy.
cpptango only relies on omniorb and it is ABI compatible between patch releases.
Compiling with 4.3.0 and using 4.3.2 at run time works fine. I would prefer to not change the run-export.

I know that omniorb and omniorbpy come from the same svn repo.
Maybe it would make sense to move omniorbpy to the omniorb-feedstock and build it as another output?
It would then be easy to pin the dependency to the exact package. And that would make sure they are updated at the same time.

@ymontmarin
Copy link
Contributor

@conda-forge-admin, please restart ci

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@ymontmarin ymontmarin merged commit ce71282 into conda-forge:main May 2, 2024
12 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 5.8.0_h135d5b branch May 2, 2024 12:31
@lockhart
Copy link

lockhart commented May 2, 2024 via email

@beenje
Copy link

beenje commented May 7, 2024

This is a long-standing problem where omniorbpy in the conda config does not constrain the omniorb pre-requisite to be the exact same version so builds a mis-matched combo. How would I adjust the omniorbpy meta.yaml (or other file) to provide this more rigorous constraint? I’m available to work on this and would like to help solve it. Thanks! - Tom

As mentioned in my comment above, I think the easiest would be to move omniorbpy to the omniorb-feedstock and archive omniorbpy-feedstock, so they are always released together.
Do you want to try?

@lockhart
Copy link

lockhart commented May 7, 2024 via email

@beenje
Copy link

beenje commented May 7, 2024

I'd look at https://conda-forge.org/docs/maintainer/knowledge_base/#multi-output-recipes

mamba-feedstock is mentioned and could be an example. It uses a single source but principle should be similar.

We can use https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#source-from-multiple-sources and use different build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants