Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Build grpcio with dynamic linking to grpc-core #72

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mariusvniekerk
Copy link
Member

@mariusvniekerk mariusvniekerk commented Jun 13, 2022

This allows grpcio to coexist must more safely with other libraries that
make use of grpc-cpp

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This allows grpcio to coexist must more safely with other libraries that
make use of grpc-cpp
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mariusvniekerk
Copy link
Member Author

cc @xhochy

@mariusvniekerk
Copy link
Member Author

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 3 commits June 13, 2022 21:47
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -59,6 +65,7 @@ test:
- grpc.framework.interfaces.face
commands:
- python -m pip check
- python distribtest.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty awesome already: is there a downstream that would stress test it further, or is it not worth it, given the number of builds? We fairly frequently get flake as it is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas can't seem to get a set of deps to actually be installable, arrow is a bit of a pain for this

@mariusvniekerk
Copy link
Member Author

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/grpcio-feedstock/actions/runs/2499632871.

@mariusvniekerk
Copy link
Member Author

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits June 15, 2022 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants