Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows builds #4

Merged
merged 11 commits into from Sep 21, 2020
Merged

Conversation

Anthchirp
Copy link
Member

@Anthchirp Anthchirp commented Sep 20, 2020

This is for #1 just to remind myself what the current issues are

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@Anthchirp
Copy link
Member Author

@conda-forge-admin, please rerender

@Anthchirp
Copy link
Member Author

Anthchirp commented Sep 20, 2020

Appears promising.

Need to look into:

  • additional files in the output directory
  • build output says "debug"
  • HDF5 runtime dependency
  • conda verify?
  • license details

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Anthchirp
Copy link
Member Author

Licensing review flagged a missing license file upstream
nexusformat/HDF5-External-Filter-Plugins#15

@Anthchirp Anthchirp marked this pull request as ready for review September 21, 2020 21:57
@Anthchirp Anthchirp changed the title See what happens if we enable Windows builds Enable Windows builds Sep 21, 2020
@Anthchirp
Copy link
Member Author

@conda-forge-admin, please rerender

@Anthchirp Anthchirp linked an issue Sep 21, 2020 that may be closed by this pull request
@Anthchirp Anthchirp merged commit dd515b2 into conda-forge:master Sep 21, 2020
@Anthchirp Anthchirp deleted the windows-build branch September 21, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds needed
2 participants