-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build hkl.3001 #13
build hkl.3001 #13
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.03.18.10.09.36
Need to update the patch Hunk #1 succeeded at 164 with fuzz 2 (offset 22 lines).
Hunk #2 FAILED at 210.
1 out of 2 hunks FAILED
Warning: failed to download source. If building, will try again after downloading recipe dependencies.
Error was:
Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmph0ibinfn/no-docs.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
Traceback (most recent call last):
File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
sys.exit(main())
File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
call_conda_build(action, config)
File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
result = api.build(
File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 180, in build
return build_tree(
File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3097, in build_tree
packages_from_this = build(metadata, stats,
File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2136, in build
try_download(m, no_download_source=False, raise_error=True)
File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 656, in try_download
raise RuntimeError("Failed to download or patch source. Please see build log for info.")
RuntimeError: Failed to download or patch source. Please see build log for info.
##[error]Bash exited with code '1'.
Finishing: Run docker build |
In the patch: -dnl *** gtk-doc ***
-GTK_DOC_CHECK([1.9],[--flavour no-tmpl]) This patch could remain but the @@ -213,12 +210,6 @@ AC_CONFIG_FILES([Makefile
tests/Makefile
tests/bindings/Makefile
tests/tap/Makefile
- Documentation/Makefile
- Documentation/hkl.org
- Documentation/api/Makefile
- Documentation/figures/Makefile
- Documentation/sphinx/Makefile
- Documentation/sphinx/source/conf.py
gui/Makefile
data/Makefile
contrib/Makefile This code has relocated and changed. This patch should be re-generated. |
Still this CI error:
Not sure how to resolve. |
Didn't work as expected:
|
The way past this point is to install export HDF5_CFLAGS=" -I${CONDA_PREFIX}/include" \
export HDF5_LIBS=" -L${CONDA_PREFIX}/lib -lhdf5" \ |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.03.28.18.53.36
This faliure: /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -DG_LOG_DOMAIN=\"Hkl\" -I.. -I.. -I../third-party/ -ftrack-macro-expansion=0 -I/root/miniconda/include -I/root/miniconda/include -I/root/miniconda/include/glib-2.0 -I/root/miniconda/lib/glib-2.0/include -I/root/miniconda/include -Wall -g -O2 -MT hkl-engine-template.lo -MD -MP -MF $depbase.Tpo -c -o hkl-engine-template.lo hkl-engine-template.c &&\
mv -f $depbase.Tpo $depbase.Plo
/bin/bash: line 1: --template: command not found
make[3]: *** [Makefile:1552: stamp-hkl-type-builtins.h] Error 127 is due to these lines in stamp-hkl-type-builtins.h: $(hkl_public_h_sources) $(srcdir)/hkl-type-builtins.h.template
( cd $(srcdir) && $(GLIB_MKENUMS) --template hkl-type-builtins.h.template \ Specifically, the |
Latest failure: ModuleNotFoundError: No module named 'giscanner._giscanner' 2023-03-28T21:21:55.5414492Z libtool: link: ( cd ".libs" && rm -f "libhkl.la" && ln -s "../libhkl.la" "libhkl.la" )
2023-03-28T21:21:55.5463192Z CPPFLAGS="-DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include" CFLAGS="-Wall -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/hkl-5.0.0.3001 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix" LDFLAGS="-Wl,-O2 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--disable-new-dtags -Wl,--gc-sections -Wl,--allow-shlib-undefined -Wl,-rpath,$PREFIX/lib -Wl,-rpath-link,$PREFIX/lib -L$PREFIX/lib" CC="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-cc" PKG_CONFIG="$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-pkg-config" GI_HOST_OS="" DLLTOOL="false" $PREFIX/bin/g-ir-scanner --add-include-path=. --add-include-path=. --warn-all --namespace=Hkl --nsversion=5.0 --libtool="/bin/sh ../libtool" --pkg=gobject-2.0 --pkg-export=hkl-5.0 --library=libhkl.la --warn-all --c-include='hkl.h' --cflags-begin -DG_LOG_DOMAIN=\"Hkl\" -I.. -I.. -I../third-party/ -ftrack-macro-expansion=0 -I$PREFIX/include/glib-2.0 -I$PREFIX/lib/glib-2.0/include -I$PREFIX/include -I$BUILD_PREFIX/include -I$PREFIX/include -I$PREFIX/include/glib-2.0 -I$PREFIX/lib/glib-2.0/include -I$PREFIX/include --cflags-end ../hkl.h hkl-binding-private.h hkl-types.h hkl-vector.c hkl-matrix.c hkl-quaternion.c hkl-parameter.c hkl-axis.c hkl-geometry.c hkl-detector.c hkl-detector-factory.c hkl-lattice.c hkl-sample.c hkl-pseudoaxis.c hkl-factory.c hkl-binding.c hkl-types.c hkl-type-builtins.c hkl-type-builtins.h $PREFIX/bin/g-ir-scanner libhkl.la Makefile --output Hkl-5.0.gir
2023-03-28T21:21:55.6462585Z Traceback (most recent call last):
2023-03-28T21:21:55.6464146Z File "/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/bin/g-ir-scanner", line 98, in <module>
2023-03-28T21:21:55.6464811Z from giscanner.scannermain import scanner_main
2023-03-28T21:21:55.6465744Z File "/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/gobject-introspection/giscanner/scannermain.py", line 35, in <module>
2023-03-28T21:21:55.6466683Z from giscanner.ast import Include, Namespace
2023-03-28T21:21:55.6467593Z File "/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/gobject-introspection/giscanner/ast.py", line 29, in <module>
2023-03-28T21:21:55.6468757Z from .sourcescanner import CTYPE_TYPEDEF, CSYMBOL_TYPE_TYPEDEF
2023-03-28T21:21:55.6469908Z File "/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/gobject-introspection/giscanner/sourcescanner.py", line 34, in <module>
2023-03-28T21:21:55.6470842Z from giscanner._giscanner import SourceScanner as CSourceScanner
2023-03-28T21:21:55.6471366Z ModuleNotFoundError: No module named 'giscanner._giscanner'
2023-03-28T21:21:55.6602054Z make[3]: *** [/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/share/gobject-introspection-1.0/Makefile.introspection:156: Hkl-5.0.gir] Error 1
2023-03-28T21:21:55.6608979Z make[3]: Leaving directory '$SRC_DIR/hkl'
2023-03-28T21:21:55.6611669Z make[2]: *** [Makefile:1181: all-recursive] Error 1
2023-03-28T21:21:55.6612463Z make[2]: Leaving directory '$SRC_DIR/hkl'
2023-03-28T21:21:55.6626350Z make[1]: *** [Makefile:566: all-recursive] Error 1
2023-03-28T21:21:55.6627513Z make[1]: Leaving directory '$SRC_DIR'
2023-03-28T21:21:55.6630835Z make: *** [Makefile:450: all] Error 2
2023-03-28T21:21:56.0569448Z Traceback (most recent call last):
2023-03-28T21:21:56.0570394Z File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
2023-03-28T21:21:56.0579287Z sys.exit(main())
2023-03-28T21:21:56.0580297Z File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
2023-03-28T21:21:56.0580827Z call_conda_build(action, config)
2023-03-28T21:21:56.0581241Z File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
2023-03-28T21:21:56.0582379Z result = api.build(
2023-03-28T21:21:56.0583098Z File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 180, in build
2023-03-28T21:21:56.0592526Z return build_tree(
2023-03-28T21:21:56.0593755Z File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3078, in build_tree
2023-03-28T21:21:56.0615761Z packages_from_this = build(metadata, stats,
2023-03-28T21:21:56.0616399Z File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2198, in build
2023-03-28T21:21:56.0627506Z utils.check_call_env(cmd, env=env, rewrite_stdout_env=rewrite_env,
2023-03-28T21:21:56.0629961Z File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 451, in check_call_env
2023-03-28T21:21:56.0648182Z return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
2023-03-28T21:21:56.0649142Z File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 427, in _func_defaulting_env_to_os_environ
2023-03-28T21:21:56.0649664Z raise subprocess.CalledProcessError(proc.returncode, _args)
2023-03-28T21:21:56.0650416Z subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/hkl_1680038274201/work/conda_build.sh']' returned non-zero exit status 2.
2023-03-28T21:22:01.6447863Z ##[error]Bash exited with code '1'.
2023-03-28T21:22:01.6495529Z ##[section]Finishing: Run docker build |
In some other projects, this error has been resolved by |
Coming to the same conclusion. I'm revising the test now to relax the extra asserts I just added. |
Before I completely surrender on this, I'll ask AI for some assist. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I think cf7a562 made sense. We needed to list the source files, per https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#source-files. |
That URL suggests the test be refactored into the style of |
I second @klauer's suggestion to exclude the pypy builds for this project. |
Lovely!
|
As @klauer said, CI is passing on all the workflows that matter to me. This one problem workflow has become a distraction since insufficient diagnostics are available to identify the root problem for this one workflow. |
So we just ignore the failing workflow or is there some action we take?
|
For example: conda-forge/staged-recipes#20694 |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.10.03.16.12.15
BTW, found that way to exclude PyPY from a web search. |
All enabled workflows have succeeded. Ready for review. Again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now this actually runs on the CI and works. Exciting!
recipe/meta.yaml
Outdated
skip: True # [py<36 or win or osx] | ||
number: 0 | ||
skip: true # [python_impl == 'pypy'] | ||
skip: True # [py<38 or py>312 or win or osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected this to be in a single line with the python_impl == 'pypy' or
but apparently either way works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for pushing on that, @prjemian!
I made a minor non-blocking suggestion below.
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
@strempfer: These geometries will be part of the support with the new library version (code changes will be necessary for hklpy to expose them, so that upgrade will happen soon):
|
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)