Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python38 #43

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/13837, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'hyperspy' output doesn't have any tests.
  • It looks like the 'hyperspy-dev' output doesn't have any tests.

- natsort
- dask >=0.18
- traits >=4.5
- requests
- tqdm >=0.4.9
- python-dateutil >=2.5
- pint >0.8
- pint >0.8,<0.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove <0.10 and not run the test suite, since we know that the test suite is working fine?
For the record, some tests fail because with pint 0.9, we have u, while with pint 0.10, we have μ.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is better to leave it as is, because otherwise, if somebody runs the tests locally, they'll fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I am fine with both.

@ericpre
Copy link
Member

ericpre commented Jan 23, 2020

Other than the comments above, this looks good to me!
I have tested it locally and the python 3.8 works fine on linux.

@ericpre
Copy link
Member

ericpre commented Jan 23, 2020

The build on win_python3.8 is hanging in the test suite... not sure if this azure glitch; it started to do the same with the previous commit for linux_python3.8, but in the last one, it works!

I have tested on windows and it worked fine (modulo a test failure due to the formatting of a time zone, most likely due to windows 10).

For info, jupyter does not seem to work well at the moment on windows with python 3.8: jupyter/notebook#4613

@francisco-dlp
Copy link
Contributor

It's more likely fine, but I've rerun the test to be sure.

@ericpre
Copy link
Member

ericpre commented Jan 24, 2020

It looks like the issue is reproducible, but we can merge this PR and sort out the python 3.8 build on windows in the next release. In the mean time, I will try to work out this issue using the development branch.

@ericpre
Copy link
Member

ericpre commented Jan 24, 2020

On a development branch, it works (even if there is another issue, which is fixable):
https://dev.azure.com/ericpre/hyperspy-feedstock/_build/results?buildId=246

@francisco-dlp
Copy link
Contributor

After rerunning it once more it has passed.

@francisco-dlp francisco-dlp merged commit 10c31e5 into conda-forge:master Jan 24, 2020
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python38-0-1 branch January 24, 2020 16:07
@ericpre
Copy link
Member

ericpre commented Jan 25, 2020

For info, jupyter does not seem to work well at the moment on windows with python 3.8: jupyter/notebook#4613

The last notebook works fine but the qtconsole is still having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants