Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python311 #750

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

  • numpy
    and potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3325621304, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

The dependence on pandas in the test suite here creates a circular dependence (including build and test deps):

hypothesis -> pandas -> numpy -> hypothesis

Unfortunately (well, depending on POV), hypothesis is not an optional test-dependence for numpy (I tried disabling it). To break this circularity, we could disable the test suite in either project, but I don't want to do this for a more "end-user" facing project like numpy, whereas (to my mind) hypothesis is mostly used within other test suites.

If pandas (and/or django, depending on what dependencies that needs) is an optional test dependency here, it would also suffice to just add # [py<311] for the moment.

@@ -38,7 +38,8 @@ requirements:
test:
requires:
- django
- pandas
# Break circular test dependency while bootstrapping Python 3.11
- pandas # [py<311]
- pip
imports:
- hypothesis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also have to comment out the test import for hypothesis.extra.pandas:

ModuleNotFoundError: No module named 'numpy'
import: 'hypothesis.extra.pandas'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally then I'll push an amended commit

@chrisburr chrisburr force-pushed the rebuild-python311-0-1_h76d91a branch from 6570cf0 to 4ce0c90 Compare October 26, 2022 07:00
@h-vetinari
Copy link
Member

Looks good! Thanks a lot! :)

automerge-label? 🙃

@chrisburr chrisburr merged commit 2adef37 into conda-forge:main Oct 26, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python311-0-1_h76d91a branch October 26, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants