Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to JupyterLab 4.0.0a31 #350

Merged
merged 5 commits into from
Nov 20, 2022
Merged

Update to JupyterLab 4.0.0a31 #350

merged 5 commits into from
Nov 20, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 18, 2022 •
edited by bollwyvl
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jtpio
Copy link
Member Author

jtpio commented Nov 18, 2022

@conda-forge-admin, please rerender

@jtpio jtpio marked this pull request as ready for review November 18, 2022 10:30
jtpio
jtpio commented Nov 18, 2022
View reviewed changes
recipe/meta.yaml
@@ -33,8 +33,7 @@ requirements:
- jinja2 >=3.0.3
- jupyter_core
- jupyter-lsp >=1.5.1
- jupyter_server >=1.16.0,<3
- jupyter_ydoc >=0.2.0,<0.3.0
- jupyter_server >=2.0.0rc3,<3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be blocking on jupyter_server 2 to be available on conda.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need to add the jupyter_server_rc channel:
https://github.com/conda-forge/jupyter_server-feedstock/pull/102/files#diff-999d2f034982a9a29cc0f5a5340497f76ff9243576ea74e5954ec5ad5f32b74cR6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://anaconda.org/conda-forge/jupyter_server/files?channel=jupyter_server_rc

@bollwyvl
Copy link
Contributor

@conda-forge-admin please rerender

@bollwyvl bollwyvl added the automerge Merge the PR when CI passes label Nov 18, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@bollwyvl
Copy link
Contributor

bollwyvl commented Nov 19, 2022 via email

fcollonval
fcollonval requested changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump jupyter server ydoc

recipe/meta.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Nov 19, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@bollwyvl
Copy link
Contributor 

+ pip check
jupyter-server-ydoc 0.4.0 requires jupyter-server-fileid, which is not installed.

oof this depedency stack (heap? mound?) is not giving me warm feelings.

@bollwyvl bollwyvl mentioned this pull request Nov 19, 2022
Merged
5 tasks
@bollwyvl
Copy link
Contributor

conda-forge/jupyter_server_ydoc-feedstock#13

@bollwyvl
Copy link
Contributor

While we could theoretically just add that dependency, i think it's more important the stack of already-shipped deps is solid rather than getting an alpha out within some specific timeframe...

@bollwyvl
Copy link
Contributor

bollwyvl commented Nov 20, 2022 via email

@bollwyvl
Copy link
Contributor

Some observations:

+ jupyter labextension list
JupyterLab v4.0.0a31
/home/conda/feedstock_root/build_artifacts/jupyterlab_1668971729072/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/share/jupyter/labextensions
        jupyterlab_pygments v0.2.2 enabled  X (python, jupyterlab_pygments)


"jupyterlab_pygments@0.2.2" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab              Extension               Package
>=4.0.0-alpha.16 <4.1.0 >=3.1.0 <4.0.0          @jupyterlab/application

@bollwyvl bollwyvl mentioned this pull request Nov 20, 2022
Closed
@bollwyvl bollwyvl merged commit 3e93b1f into conda-forge:alpha-4.x Nov 20, 2022
@jtpio jtpio deleted the alpha-31 branch November 21, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval requested changes

@afshin afshin Awaiting requested review from afshin afshin is a code owner

@blink1073 blink1073 Awaiting requested review from blink1073 blink1073 is a code owner

@bollwyvl bollwyvl Awaiting requested review from bollwyvl bollwyvl is a code owner

@ellisonbg ellisonbg Awaiting requested review from ellisonbg ellisonbg is a code owner

@ian-r-rose ian-r-rose Awaiting requested review from ian-r-rose ian-r-rose is a code owner

@jasongrout jasongrout Awaiting requested review from jasongrout jasongrout is a code owner

@jochym jochym Awaiting requested review from jochym jochym is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtpio @conda-forge-linter @bollwyvl @fcollonval