Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #5

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Jun 2, 2023

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5153250899, please use this URL for debugging.

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libblas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham changed the title Rebuild for CUDA 12 The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libblas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( https://github.com/conda-forge/conda-forge.github.io/issues/1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏 Rebuild for CUDA 12 Jun 2, 2023
@jakirkham
Copy link
Member

Seeing the following error on CI:

CMake Error at CMakeLists.txt:263 (target_link_libraries):
  Target "katago" links to:

    CUDA::cublas

  but the target was not found.

As the new CUDA 12 packages split all these components up ( conda-forge/staged-recipes#21382 ), think we need to add libcublas-dev to host:

  host:
    - libcublas-dev      # [(cuda_compiler_version or "").startswith("12")]

Note that *-dev suffixed packages have headers and dynamic libraries. They add the * package (no -dev suffix) to run automatically via run_exports

Edit: For more info about the CUDA 12 bringup, please see issue ( conda-forge/conda-forge.github.io#1963 )

@jakirkham
Copy link
Member

Looks like the build is running into an error trying to use compute_35 with CUDA 12 on CI, which is an unsupported architecture for CUDA 12

nvcc fatal   : Unsupported gpu architecture 'compute_35'

Appears related to upstream issue ( lightvector/KataGo#725 )

@hadim
Copy link
Member

hadim commented Jun 8, 2023

Thanks for looking into it @jakirkham. It looks like there is not much to-do here besides waiting for upstream.

@jakirkham
Copy link
Member

Might be worth asking upstream if there is an update. That issue hasn't been touched for a while. Perhaps they can advise a path forward (like some kind of workaround)

@jakirkham
Copy link
Member

Converting to draft while we wait for an upstream update

@jakirkham
Copy link
Member

Think we may be able to bypass this issue by specifying the GPU architectures to use

Would suggest borrowing this logic to specify the GPU architectures via the CMake respected CUDAARCHS environment variable. Here's some more details on how it works

@jakirkham jakirkham added the bot-rerun Instruct the bot to retry the PR label Aug 24, 2023
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/5968502524

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_h1df139 branch August 24, 2023 20:20
@jakirkham
Copy link
Member

Superseded by PR: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants