Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting v11 #57

Closed
wants to merge 2 commits into from
Closed

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 8, 2022

It just reached end of life, see gazebo-tooling/release-tools#655 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437215.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437384.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437513.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437673.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437440.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116438861.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116440372.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116440455.

@Tobias-Fischer
Copy link
Contributor

This is still being used in robostack. Do we know if ROS supports newer versions without issues?

@traversaro
Copy link
Contributor Author

This is still being used in robostack. Do we know if ROS supports newer versions without issues?

Interesting, I had no idea. The original repo is using sdformat9 (the one used in Gazebo Classic) , any idea why we patch it to use sdformat11 in https://github.com/RoboStack/ros-galactic/blob/9a8356042c270b69f77f2d8ef341ed807d3e5ea4/patch/ros-galactic-sdformat-urdf.patch instead?

@Tobias-Fischer
Copy link
Contributor

I think because the ignition libraries that are pulled in (https://github.com/RoboStack/ros-noetic/blob/e5a20fca7f3882c9713460ab593d8ba826abc6ee/conda.yaml#L140-L159) only work with sdformat11?!? But I could be totally wrong.

@traversaro
Copy link
Contributor Author

@Tobias-Fischer I guess we can go on with this now that all the effort on robostack has been moved to humble, right?

@Tobias-Fischer
Copy link
Contributor

Hmmm, ideally we would like to support Noetic for a little while - this is a big attraction of RoboStack. I’m not sure if we can move Noetic to newer versions though?

@traversaro
Copy link
Contributor Author

traversaro commented Jun 6, 2023

Hmmm, ideally we would like to support Noetic for a little while - this is a big attraction of RoboStack. I’m not sure if we can move Noetic to newer versions though?

Noetic uses libsdformat package, i.e. sdformat9 (see https://github.com/RoboStack/ros-noetic/blob/e4c4e41afa60975a260dfe0ab2ebce25e11993b9/robostack.yaml#L833). What I want to drop support for is sdformat11 .

@Tobias-Fischer
Copy link
Contributor

Ah apologies, I should have read the whole issue before replying. All good with me, happy to stop the support for v11

@traversaro traversaro closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants